Fixes #258 Add clearer doc for JSON schema's default keyword#259
Merged
mothslaw merged 2 commits intodelphix:developfrom Oct 9, 2020
Merged
Fixes #258 Add clearer doc for JSON schema's default keyword#259mothslaw merged 2 commits intodelphix:developfrom
mothslaw merged 2 commits intodelphix:developfrom
Conversation
ravi-cm
reviewed
Oct 7, 2020
nhlien93
approved these changes
Oct 8, 2020
Contributor
nhlien93
left a comment
nhlien93
left a comment
There was a problem hiding this comment.
yup, just adding the one line about what it actually is used for would be my only comment as well.
jeffngo
approved these changes
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
No mention of
defaultWhat is the new behavior?
Added a warning about misinterpreting JSON schema's
defaultkeyword. (Also fixed a couple of incorrect quote characters)Does this introduce a breaking change?
Other information